GridColumn to only apply displayWidth to multiLine columns#1900
Merged
GridColumn to only apply displayWidth to multiLine columns#1900
Conversation
labkey-nicka
approved these changes
Nov 24, 2025
| } | ||
|
|
||
| // only apply the displayWidth, if avaialble, to multiLine text columns | ||
| const _displayWidth = c.rangeURI?.endsWith('multiLine') ? c.displayWidth : undefined; |
Contributor
There was a problem hiding this comment.
nit: It'd be nice to keep logic out of Grid.tsx related to query modeling.
Contributor
Author
There was a problem hiding this comment.
@labkey-nicka good point. I moved the logic over to the QueryColumn constructor. Thoughts on this approach?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Previous related PR started using the displayWidth from the QueryColumn in the GridColumn for the width. However, this was passing through null and empty string values from the server which meant that the default width for the GridColumn wasn't being set. This PR fixes that but also scopes down this change so that the non-empty displayWidth only applies to multiLine text columns (we can reassess having this apply to other columns at a later date).
Related Pull Requests
Changes